Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from microsoft/usvc-apiserver #6560

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[main] Update dependencies from microsoft/usvc-apiserver #6560

merged 1 commit into from
Oct 30, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 30, 2024 •
edited by dotnet-policy-service bot
Loading

This pull request updates the following dependencies

From https://github.com/microsoft/usvc-apiserver

  • Subscription: 852f69a6-643d-499a-6cb6-08dbca4ebb98
  • Build: 0.8.13
  • Date Produced: October 30, 2024 6:16:27 PM UTC
  • Commit: 9582c787e7963a2acf11111e5bc5a4938e7fe3ab
  • Branch: refs/tags/v0.8.13
Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro
Update dependencies from https://github.com/microsoft/usvc-apiserver …
a7eee56 
…build 0.8.13

Microsoft.DeveloperControlPlane.darwin-amd64 , Microsoft.DeveloperControlPlane.darwin-arm64 , Microsoft.DeveloperControlPlane.linux-amd64 , Microsoft.DeveloperControlPlane.linux-arm64 , Microsoft.DeveloperControlPlane.windows-386 , Microsoft.DeveloperControlPlane.windows-amd64 , Microsoft.DeveloperControlPlane.windows-arm64
 From Version 0.8.11 -> To Version 0.8.13
@build-analysis build-analysis bot mentioned this pull request Oct 30, 2024
Open
@DamianEdwards
Copy link
Member

@karolz-ms @eerhardt @davidfowl is this failure deliberately failing the run if any instances of dotnet-tests, dcp, or dcpctrl are found? It seems to be getting a hit on dotnet itself and forcing a non-zero exit?
image

@davidfowl
Copy link
Member

cc @radical

@eerhardt
Copy link
Member

@karolz-ms @eerhardt @davidfowl is this failure deliberately failing the run if any instances of dotnet-tests, dcp, or dcpctrl are found? It seems to be getting a hit on dotnet itself and forcing a non-zero exit? image

I don't htink it is purposefully failing the build. It looks like it is just trying to clean up hanging processes:

aspire/tests/helix/send-to-helix-inner.proj

Lines 61 to 62 in 13bcaa0

<_CleanupProcessesCommand Condition="'$(OS)' == 'Windows_NT'">powershell -ExecutionPolicy ByPass -NoProfile -command "&amp; get-ciminstance win32_process | where-object ExecutablePath -Match 'dotnet-tests|dcp.exe|dcpctrl.exe' | foreach-object { echo $_.ProcessId $_.ExecutablePath %3B stop-process -id $_.ProcessId -force -ErrorAction SilentlyContinue }"</_CleanupProcessesCommand>
<_CleanupProcessesCommand Condition="'$(OS)' != 'Windows_NT'">pgrep -lf "dotnet-tests|dcp.exe|dcpctrl.exe" | awk '{print %3B system("kill -9 "$1)}'</_CleanupProcessesCommand>

I'm not sure what is returning 1....

@DamianEdwards
Copy link
Member

I'm not sure what is returning 1....

We seem to have lots of exit 1 calls in eng/build.sh

@karolz-ms
Copy link
Member

If you look at the logs (towards the end) https://helix.dot.net/api/2019-06-17/jobs/b3620043-5064-421c-b2af-da5741da835f/workitems/Aspire.Playground.Tests/console it seems like the test passed, but then the cleanup failed with code 1 ?

@DamianEdwards
Copy link
Member

If you look at the logs (towards the end) https://helix.dot.net/api/2019-06-17/jobs/b3620043-5064-421c-b2af-da5741da835f/workitems/Aspire.Playground.Tests/console it seems like the test passed, but then the cleanup failed with code 1 ?

Right, exactly. Trying to figure out what caused it to exit 1.

@DamianEdwards
Copy link
Member

DamianEdwards commented Oct 30, 2024 •
edited
Loading

Something seems to be printing a list of dotnet processes immediately beforehand

@radical
Copy link
Member

radical commented Oct 30, 2024

That exit 1 is because the tests run actually got aborted:

Aborting test run: test run timeout of 1200000 milliseconds exceeded.
Results File: /datadisks/disk1/work/9C3608FE/w/ACF008F5/uploads/logs/TestResults.trx

Passed!  - Failed:     0, Passed:    16, Skipped:     0, Total:    16, Duration: 17 m 51 s - Aspire.Playground.Tests.dll (net8.0)
Test Run Aborted.

Code coverage results: /datadisks/disk1/work/9C3608FE/w/ACF008F5/uploads/logs/Aspire.Playground.Tests.cobertura.xml.
+ export _commandExitCode=1

And the last line above sets _commandExitCode=1 because of the tests being aborted, and that is the final exit code returned.

@DamianEdwards
Copy link
Member

@radical aha! Seems we just weren't reading the log file hard enough 😄

So this was a typical timeout then? Just re-run and hope for the best?

@radical
Copy link
Member

radical commented Oct 30, 2024

The playground tests passed on this run. I'll open a separate PR to improve the test output that we get. This regressed for us when we switched to the newer msbuild.

@DamianEdwards DamianEdwards enabled auto-merge (squash) October 30, 2024 23:10
@DamianEdwards DamianEdwards merged commit df42920 into main Oct 30, 2024
9 of 10 checks passed
@DamianEdwards DamianEdwards deleted the darc-main-5baa08a9-f120-4828-a62c-5f62ca7086ae branch October 30, 2024 23:23
@karolz-ms
Copy link
Member

/backport to release/9.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11616480268

@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Merged
@davidfowl davidfowl mentioned this pull request Nov 1, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karolz-ms karolz-ms karolz-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DamianEdwards @davidfowl @eerhardt @karolz-ms @radical