Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider increasing frequency of app host health checks update during startup #6536

Open
DamianEdwards opened this issue Oct 28, 2024 · 0 comments
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Milestone

Comments

@DamianEdwards
Copy link
Member

As the number of resources using WaitFor increases in an app project in such a way that a longer sequential "wait-for chain" is build up, the impact of the accumulated downtime between health checks updates increases.

For example, the Aspire Shop sample was updated for Aspire 9 to use WaitFor for four resources, that results in the following wait-for chains:

flowchart LR
    B[basketService] -->| waits for | C[baksetCache]
    F[frontend] -->| waits for | D[catalogService] -->| waits for | E[catalogDbManager] -->| waits for | G[catalogDb]
Loading

If the update frequency for app host health checks is 1 second, then the longer chain shown above could result in up to 3 extra seconds of startup time.

We should consider increasing the frequency of health check updates during startup to something much tighter to minimize the impact of longer wait-for chains.

/Cc @mitchdenny

@DamianEdwards DamianEdwards added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Oct 28, 2024
@joperezr joperezr added the untriaged New issue has not been triaged label Oct 28, 2024
@joperezr joperezr added this to the Backlog milestone Oct 29, 2024
@joperezr joperezr removed the untriaged New issue has not been triaged label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

No branches or pull requests

2 participants