-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress the API breakchange introduced by PR 1354 and bump up minor version #1356
Comments
Let's fix the API breakage instead of suppressing it. @yueyinqiu -- if you could resubmit your earlier PR, without removing the single-parameter 'Connect', that would be helpful. |
Hmm... I will check that. I just considered about the compatibility of the source code and ignored the binary compatibility. I think that pr could be modified to hold the extra overloads thus keeping binary compatibility, but I wonder what should we do if there have to be some API changes? I think in the current stage API changes are still common and welcomed. |
I'm also facing some problems when checking the API compatibility locally. I tried The first problem is that actually it should be compared with Actually I still believe it's too early to check about the API compatibilities. |
#1354 introduce API break change, we need to check in a suppression file to overpass the API compatibility check and bump the version
The text was updated successfully, but these errors were encountered: