Prefer xref over code-style #33853
Open
Prefer xref over code-style #33853
+68
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdykstra
approved these changes
Oct 15, 2024
|
@tdykstra @captainsafia I've switched the links to use a style like Tom suggested, but I had added one more stylistic twist. In cases where the link was to an attribute and was followed by "attribute", I moved "attribute" inside the link text. Likewise for "extension method". Here's a snip that shows how this looks now:
I don't have strong feelings about this but it seems worth trying. Let me know if you like it better the other way and I can easily change it. |
I don't either, so I'd be interested in getting input from @captainsafia and @Rick-Anderson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts code-style references to .NET classes to xref references.
Prior to this there was a mix of code-style and xref references in this file.
Internal previews