Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remark on DP protection of persisted component state #33819

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Oct 8, 2024

@guardrex guardrex requested a review from javiercn October 8, 2024 09:53
@guardrex guardrex self-assigned this Oct 8, 2024
@guardrex
Copy link
Collaborator Author

guardrex commented Oct 8, 2024

prerendered data sent to a client ... in-transit

I might need to reword these remarks to make this say it's data sent round-trip for server payloads. Currently, it sounds like it's one-way server to client.

Improved on the next two commits.

@hakenr
Copy link
Contributor

hakenr commented Oct 8, 2024

My proposal:

The persisted prerendered state is transferred to the interactive client, where it's used to restore the component state. In InteractiveWebAssembly render mode, this data is exposed to the browser and must not contain any sensitive information that needs to remain secure. For InteractiveServer render mode, ASP.NET Core Data Protection ensures that data is transferred securely. InteractiveAuto render mode combines WebAssembly and Server interactivity, so it's also necessary to consider data exposure to the browser, as in the InteractiveWebAssembly case.

This is intended as a suggested level of simplification, not exact wording. I’d avoid going into details about in-transit or similar concepts.

@guardrex
Copy link
Collaborator Author

guardrex commented Oct 8, 2024

Yes, that's nice. I'll put it in place with a few NIT updates.

@guardrex
Copy link
Collaborator Author

guardrex commented Oct 8, 2024

Ok ... try it now 👀.

@guardrex
Copy link
Collaborator Author

guardrex commented Oct 8, 2024

Since we're coming to agreement, I'll drop the Javier review request.

@guardrex guardrex removed the request for review from javiercn October 8, 2024 18:55
Copy link
Contributor

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guardrex guardrex merged commit 227c640 into main Oct 8, 2024
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-pcs-dp branch October 8, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention that DP is used to secure PCS data sent to the client
2 participants