Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality related changes. #197

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Code quality related changes. #197

merged 5 commits into from
Aug 21, 2023

Conversation

alexmerlin
Copy link
Member

No description provided.

Signed-off-by: alexmerlin <[email protected]>
Signed-off-by: alexmerlin <[email protected]>
Signed-off-by: alexmerlin <[email protected]>
Signed-off-by: alexmerlin <[email protected]>
@alexmerlin alexmerlin self-assigned this Aug 18, 2023
@alexmerlin alexmerlin added the enhancement New feature or request label Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (4.0@68f8a67). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##             4.0     #197   +/-   ##
======================================
  Coverage       ?   71.02%           
  Complexity     ?      652           
======================================
  Files          ?      109           
  Lines          ?     2454           
  Branches       ?        0           
======================================
  Hits           ?     1743           
  Misses         ?      711           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmerlin
Copy link
Member Author

Note:
If anybody has an idea on why this error happens, please feel free to request changes that will fix it.
For now, the only solution I had was to phpcs ignore the list of ConfigProviders in config/config.php, but obviously, this is not the right solution.

Copy link
Member

@arhimede arhimede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me
too many files to be able to have a proper review

@arhimede arhimede merged commit 7f86980 into 4.0 Aug 21, 2023
11 checks passed
@arhimede arhimede deleted the issue-193 branch August 21, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codecov badge php 8.2 composer install errors github actions + symfony badge codecov integration
2 participants