Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches for HasSupportFragmentInjector and HasFragmentInjector #43

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bhm
Copy link
Contributor

@bhm bhm commented Oct 2, 2017

No description provided.

@MasterAccountIFM
Copy link

--- JIRA LINKS ---

@@ -22,4 +27,8 @@ class SampleApp : Application(), HasActivityInjector {

override fun activityInjector(): AndroidInjector<Activity> = dispatchingAndroidInjector

override fun fragmentInjector(): AndroidInjector<android.app.Fragment> = dispatchingFragmentInjector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was is das ?

Copy link
Contributor Author

@bhm bhm Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need it to have Fragments injected in the app. Android's fragments or support ones. Or both, since technically you can have both, for whatever reason.

Without these dispatching injectors Dagger goes \(ツ)

Forgot about import alias, so I may opt out for a SupportFragment alias instead of full package path.

@bhm bhm force-pushed the switches-for-dispatching-injectors branch from 9579356 to 9b7cd60 Compare October 13, 2017 14:30
@bhm bhm force-pushed the switches-for-dispatching-injectors branch from 9b7cd60 to f77e0d1 Compare October 13, 2017 14:31
@bhm
Copy link
Contributor Author

bhm commented Oct 13, 2017

This got updated

@bhm
Copy link
Contributor Author

bhm commented Oct 15, 2018

@rainqer do we care to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants