Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No issue: adding E2E missing javadoc #30072

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

No issue: adding E2E missing javadoc #30072

wants to merge 3 commits into from

Conversation

victoralfaro-dotcms
Copy link
Contributor

No description provided.

@victoralfaro-dotcms victoralfaro-dotcms marked this pull request as ready for review September 19, 2024 03:05
@victoralfaro-dotcms victoralfaro-dotcms added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@victoralfaro-dotcms victoralfaro-dotcms added this pull request to the merge queue Sep 19, 2024
@victoralfaro-dotcms victoralfaro-dotcms removed this pull request from the merge queue due to a manual request Sep 19, 2024
@victoralfaro-dotcms victoralfaro-dotcms requested a review from a team as a code owner September 19, 2024 16:53
spbolton
spbolton reviewed Sep 19, 2024
View reviewed changes
.github/filters.yaml Outdated Show resolved Hide resolved
@spbolton
Copy link
Contributor

spbolton commented Sep 19, 2024 •
edited
Loading

These issues were only found on the merge queue as e2e changes were not triggering running in PR. These should be detected and fixed

https://github.com/dotCMS/core/actions/runs/10944207433/job/30385538620#step:6:3438
https://github.com/dotCMS/core/actions/runs/10944207433/job/30385538620#step:6:3438

For the VarAgs warning here is some additional info

https://stackoverflow.com/questions/12462079/possible-heap-pollution-via-varargs-parameter
From an aI analysis “In this case, since C is bounded by AutoCloseable, and the method logic (Stream.of, filter, forEach) does not modify or store the array in a way that could cause type inconsistencies, the code should be safe. The @SafeVarargs annotation could be applied without issues, assuming you make the method final.” The method does need to be static of final to apply the annotation.

spbolton
spbolton reviewed Sep 19, 2024
View reviewed changes
.github/filters.yaml Outdated Show resolved Hide resolved
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
15 New issues
6 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@victoralfaro-dotcms victoralfaro-dotcms added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spbolton spbolton spbolton left review comments

@dsilvam dsilvam dsilvam approved these changes

@nollymar nollymar nollymar approved these changes

@jcastro-dotcms jcastro-dotcms jcastro-dotcms approved these changes

@dcolina dcolina dcolina approved these changes

@freddyDOTCMS freddyDOTCMS freddyDOTCMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@victoralfaro-dotcms @spbolton @dsilvam @nollymar @jcastro-dotcms @dcolina @freddyDOTCMS