Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clear all button in Category Field Dialog #30052

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Fix clear all button in Category Field Dialog #30052

merged 6 commits into from
Sep 20, 2024

Conversation

oidacra
Copy link
Member

@oidacra oidacra commented Sep 18, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • Fix clear all button in Category Field Dialog

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original | Updated
No visual changes

This PR fixes: #30008

@oidacra oidacra force-pushed the issue-30008-clear-selection-category-field branch from 46f35b3 to e18111b Compare September 18, 2024 20:25
@oidacra oidacra marked this pull request as ready for review September 18, 2024 20:25
@oidacra oidacra linked an issue Sep 18, 2024 that may be closed by this pull request
New Category Field: Clearing selection on side panel does not clear the selection on the tree #30008
Closed
nicobytes
nicobytes approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@nicobytes nicobytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oidacra oidacra force-pushed the issue-30008-clear-selection-category-field branch from c329ed3 to 0138e0c Compare September 19, 2024 19:52
@oidacra oidacra changed the title Fix clear all button in Category Field Dialog Fix clear all button in Category Field Dialog Sep 19, 2024
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@oidacra oidacra added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@hmoreras hmoreras added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@oidacra oidacra added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@oidacra oidacra added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit 4359825 Sep 20, 2024
18 checks passed
@oidacra oidacra deleted the issue-30008-clear-selection-category-field branch September 20, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjvelazco rjvelazco rjvelazco approved these changes

@hmoreras hmoreras hmoreras approved these changes

@nicobytes nicobytes nicobytes approved these changes

@zJaaal zJaaal Awaiting requested review from zJaaal

@KevinDavilaDotCMS KevinDavilaDotCMS Awaiting requested review from KevinDavilaDotCMS

@valentinogiardino valentinogiardino Awaiting requested review from valentinogiardino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Category Field: Clearing selection on side panel does not clear the selection on the tree
4 participants
@oidacra @nicobytes @hmoreras @rjvelazco