Issue 29238 Attaching files feature on tasks is not properly working #29992
+105
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcastro-dotcms
approved these changes
Sep 17, 2024
dotCMS/src/main/java/com/dotmarketing/portlets/fileassets/business/FileAssetAPIImpl.java
Outdated
Show resolved
Hide resolved
dsolistorres
approved these changes
Sep 18, 2024
…//github.com/dotCMS/core into issue-29238-Attaching-files-feature-on-tasks
erickgonzalez
approved these changes
Sep 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jdotcms
reviewed
Sep 20, 2024
dotCMS/src/main/java/com/dotmarketing/portlets/fileassets/business/FileAssetAPI.java
Outdated
Show resolved
Hide resolved
jdotcms
reviewed
Sep 20, 2024
dotCMS/src/main/java/com/dotmarketing/portlets/fileassets/business/FileAssetAPIImpl.java
Outdated
Show resolved
Hide resolved
jdotcms
reviewed
Sep 20, 2024
dotCMS/src/main/java/com/dotmarketing/portlets/workflows/business/WorkflowAPI.java
Outdated
Show resolved
Hide resolved
|
erickgonzalez
deleted the
issue-29238-Attaching-files-feature-on-tasks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attaching dot assets it was throwing an exception that the file wasn't a file asset, so I implemented a conversion from dotAsset to fileAsset, first made the convertToFileAsset function public and static to be accessible from outside its class and to reuse the logic of that function.
Then implemented the extra logic to convert the dotAsset to fileAsset in a new function transformDotAsset, where also a new property "fileLink" is added to then display it in the href of the jsp, this way the file can be accessible without problem when clicking on it.
This PR fixes: #29238