Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot-content-types-listing: Use the new Angular Syntax #30085

Closed
Tracked by #29797
nicobytes opened this issue Sep 20, 2024 · 1 comment · Fixed by #30095
Closed
Tracked by #29797

dot-content-types-listing: Use the new Angular Syntax #30085

nicobytes opened this issue Sep 20, 2024 · 1 comment · Fixed by #30095
Labels
dotCMS : Upgrade Gardening Day QA : Approved Release : 24.09.25 Bug Fixing Team : Falcon

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Sep 20, 2024 •
edited
Loading

Parent Issue

#29797

Task

Using the nx g @angular/core:control-flow command to migrate to the new Angular syntax.

Why?

The goal is to improve performance and code maintainability.
@nicobytes nicobytes mentioned this issue Sep 20, 2024
Open
nicobytes added a commit that referenced this issue Sep 20, 2024
@nicobytes
feat(editor-content): use new angular syntax in content types list #3…
2903a97 
…0085
@nicobytes nicobytes mentioned this issue Sep 20, 2024
Merged
3 tasks
@nicobytes nicobytes linked a pull request Sep 20, 2024 that will close this issue
feat(editor-content): use new angular syntax in content types and templates #30095
Merged
3 tasks
nicobytes added a commit that referenced this issue Sep 20, 2024
@nicobytes
feat(editor-content): use new angular syntax in template list #30085
6d7a748
@nicobytes nicobytes self-assigned this Sep 20, 2024
nicobytes added a commit that referenced this issue Sep 20, 2024
@nicobytes
feat(editor-content): fix error with th #30085
3294e1c
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@nicobytes
feat(editor-content): use new angular syntax in content types and tem…
e38db41 
…plates (#30095)

### Parent Issue

#30085 

### Proposed Changes
* Use the new Angular syntax in `/content-types-angular` `/templates`
* Use the new Angular syntax in `dot-listing-data-table` component

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Videos

Manual tests in  `/templates`


https://github.com/user-attachments/assets/85fa0477-0218-4038-9687-0b11d7c73280

Manual tests in  `/content-types-angular`


https://github.com/user-attachments/assets/f88ac9ed-6d32-4cf5-a4f9-80dde63ee78f
@nicobytes nicobytes removed their assignment Sep 23, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_477606b, Docker, macOS 14.5, FF v126.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotCMS : Upgrade Gardening Day QA : Approved Release : 24.09.25 Bug Fixing Team : Falcon
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(editor-content): use new angular syntax in content types and templates dotCMS/core
2 participants
@nicobytes @josemejias11