Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display private sets for admins when fetch /all #75

Open
LarsFlieger opened this issue Jun 16, 2022 · 0 comments
Open

Display private sets for admins when fetch /all #75

LarsFlieger opened this issue Jun 16, 2022 · 0 comments
Assignees
Milestone

Comments

@LarsFlieger
Copy link
Contributor

LarsFlieger commented Jun 16, 2022

As of now fetching the sets from the public endpoint with an admin account will return every set (including private).
This hinders the ability of the admin account to play the game normally as private sets are not relevant for the admin when playing normally.
A solution to this issue would be to introduce a query parameter that allows for specifying the desired visibility:

api/sets?visibility=all => private/public when user is admin
api/sets?visibility=private => private when user is admin
api/sets?visibility=public / api/sets => display public => doesn't matter is user is admin

default is public

@LarsFlieger LarsFlieger self-assigned this Jun 16, 2022
@coffeemakingtoaster coffeemakingtoaster added this to the v0.2 milestone Aug 15, 2022
@LarsFlieger LarsFlieger removed their assignment Aug 15, 2022
@Branchverse Branchverse self-assigned this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants