Error when new value is not JSON

[deevus]

SyntaxError: Unexpected token e in JSON at position 1
  at JSON.parse(<anonymous>)
  at current(./node_modules/use-persisted-state/dist/use-persisted-state.m.js:1:766)
  at n(./node_modules/@use-it/event-listener/dist/event-listener.m.js:1:199)
  at n(./node_modules/@sentry/browser/esm/helpers.js:70:1)

See line 12 below:

use-persisted-state/src/usePersistedState.js

Lines 11 to 16 in 02a847a

	useEventListener('storage', ({ key: k, newValue }) => {
	const newState = JSON.parse(newValue);
	if (k === key && state !== newState) {
	setState(newState);
	}
	});

Other modules may use localStorage and not store JSON.

[deevus]

It might be simple enough to short circuit when k !== key

[ricardo-devis-agullo]

Hi, I see this got fixed.

Could you publish to NPM a new version for this fix? :)

[timuric]

Would very much appreciate this fix! :)

[szymn]

@donavon any chance you could publish a new version with this fix to NPM?

[michu2k]

Hi @donavon, so can you publish to NPM a new version with this fix :) ?

[cammanderson]

Hi All, Just +1'ing this for a fix as well. Not sure if we want to make it safer to use try {} catch for added safety also?

[DatChoob]

@donavon Would really appreciate this fix

[smerth]

@donavon, +1 - looking forward to the NPM version with this fix. Thanks for the great hook

[williamgrosset]

@donavon +1! :)

[deevus]

I have tweeted @donavon here https://twitter.com/deevus/status/1221934141488283649

[Luke-Markham]

1+ broke my app because of this haha

[deevus]

It looks like some nice person has published version 0.3.1 here https://www.npmjs.com/package/@smartrent/use-persisted-state

If you don't want to change your import references to @smartrent/use-persisted-state and you use yarn, you can add it as an alias using the following command:

yarn add use-persisted-state@npm:@smartrent/use-persisted-state

[astoilkov]

I see this module is not well maintained anymore. You could check out the module I built https://github.com/astoilkov/use-local-storage-state. The good thing is we used it in our production app so maintenance should be solid.