Deprecation Warnings after upgrade to 2023-04-04a "Jack Jackrum"

[yaynstuff]

Logs are spammed with

2023-08-13 07:18:31             resolve_pageid() is deprecated. It was called from helper_plugin_include::_get_included_pages() in /home/fswiki/public_html/lib/plugins/include/helper.php:728
 dokuwiki\File\PageResolver should be used instead!

and

2023-08-13 07:18:34             resolve_id() is deprecated. It was called from helper_plugin_include::adapt_links() in /home/fswiki/public_html/lib/plugins/include/helper.php:570 dokuwiki\Fi
le\Resolver and its children should be used instead!

Please see https://www.dokuwiki.org/devel:releases:refactor2021 (specifically the "Refactoring of id resolving" section).

Could you please update the plugin to correct the deprecation issues. Thank you.

[fiwswe]

Partially similar to #292

[Autumnf0x]

Messages in DokuWiki deprecated log:

resolve_pageid() is deprecated. It was called from helper_plugin_include::adapt_links() in /var/www/dokuwiki/lib/plugins/include/helper.php:583 dokuwiki\File\PageResolver should be used instead!
resolve_id() is deprecated. It was called from helper_plugin_include::adapt_links() in /var/www/dokuwiki/lib/plugins/include/helper.php:570 dokuwiki\File\Resolver and its children should be used instead!
resolve_pageid() is deprecated. It was called from helper_plugin_include::_get_included_pages() in /var/www/dokuwiki/lib/plugins/include/helper.php:728 dokuwiki\File\PageResolver should be used instead!

• include plugin version: 2022-08-16;
• DokuWiki version: 2023-04-04a "Jack Jackrum";
• PHP 8.2;

I really hope this super plugin is still maintained.

[Autumnf0x]

May be... commit new version tag etc.? Official old version 2022-01-23 is still actual...
?

[Autumnf0x]

resolve_pageid() is deprecated. It was called from helper_plugin_include::_get_included_pages() in /var/www/dokuwiki/lib/plugins/include/helper.php:728 dokuwiki\File\PageResolver should be used instead!
resolve_id() is deprecated. It was called from helper_plugin_include::adapt_links() in /var/www/dokuwiki/lib/plugins/include/helper.php:570 dokuwiki\File\Resolver and its children should be used instead!
resolve_pageid() is deprecated. It was called from helper_plugin_include::adapt_links() in /var/www/dokuwiki/lib/plugins/include/helper.php:583 dokuwiki\File\PageResolver should be used instead!

Still actual... Is it time to fork?.. :(
Is the plugin still supported?

[Miro-Collas]

resolve_pageid() is deprecated. It was called from helper_plugin_include::_get_included_pages() in /var/www/dokuwiki/lib/plugins/include/helper.php:728 dokuwiki\File\PageResolver should be used instead!
resolve_id() is deprecated. It was called from helper_plugin_include::adapt_links() in /var/www/dokuwiki/lib/plugins/include/helper.php:570 dokuwiki\File\Resolver and its children should be used instead!
resolve_pageid() is deprecated. It was called from helper_plugin_include::adapt_links() in /var/www/dokuwiki/lib/plugins/include/helper.php:583 dokuwiki\File\PageResolver should be used instead!

Still actual... Is it time to fork?.. :( Is the plugin still supported?

If you know how to fix it, please do fork it. :-)

[Autumnf0x]

resolve_pageid() is deprecated. It was called from helper_plugin_include::_get_included_pages() in /var/www/dokuwiki/lib/plugins/include/helper.php:728 dokuwiki\File\PageResolver should be used instead!
resolve_id() is deprecated. It was called from helper_plugin_include::adapt_links() in /var/www/dokuwiki/lib/plugins/include/helper.php:570 dokuwiki\File\Resolver and its children should be used instead!
resolve_pageid() is deprecated. It was called from helper_plugin_include::adapt_links() in /var/www/dokuwiki/lib/plugins/include/helper.php:583 dokuwiki\File\PageResolver should be used instead!

Still actual... Is it time to fork?.. :( Is the plugin still supported?

If you know how to fix it, please do fork it. :-)

I would do this if I knew how to fix it and if I had the opportunity to maintain the plugin.

This was the plugin whose existence once determined my choice of DokuWiki. Warning - this is just a deprecated log. This doesn't mean the plugin doesn't work. This is not a disaster for me personally. It can work with the current version of Doku. And, if the lack of a plugin is critical, then there is time to find alternative solutions. But when a plugin is left without support, it either gets forked or dies.
DokuWiki, in turn, will eventually be left without this plugin, and this doesn't mean anything good for DokuWiki. And I don’t understand why does it make you so happy.

[Miro-Collas]

@Autumnf0x I'm not happy - it was a smile of encouragement. I made an attempt to fix the problems, as you can see in #299 - I failed. If you want a partial fix, you can pull my code from here. However, it may not work for you, you will need to test it. See the comments on the (closed) pull request.
And yes, it is just deprecated code warnings. However, eventually, that code will stop working. Hopefully someone will fix it eventually.

[Autumnf0x]

@Autumnf0x I'm not happy - it was a smile of encouragement. I made an attempt to fix the problems, as you can see in #299 - I failed. If you want a partial fix, you can pull my code from here. However, it may not work for you, you will need to test it. See the comments on the (closed) pull request. And yes, it is just deprecated code warnings. However, eventually, that code will stop working. Hopefully someone will fix it eventually.

I apologize for this misunderstanding.
If at least someone is trying, then there is hope. Even if it's a fork. Anyway, thanks for trying. I hope that I won't have to look for an alternative; despite the number of such - I am a retrograde ).

[Miro-Collas]

@Autumnf0x You can try my fork to see if it works for you. If not, it is easy to revert to the original.

[Miro-Collas]

@Autumnf0x I suggest you keep an eye on #300

[Autumnf0x]

@Autumnf0x I suggest you keep an eye on #300

Now - of course!