Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy methods in CreateCommand may be obsolete #2631

Open
jmikola opened this issue Apr 29, 2024 · 0 comments
Open

Proxy methods in CreateCommand may be obsolete #2631

jmikola opened this issue Apr 29, 2024 · 0 comments

Comments

@jmikola
Copy link
Member

jmikola commented Apr 29, 2024

Summary

The processProxy and processDocumentProxy methods in CreateCommand appear to be obsolete.

They were introduced in 373966e prior to 1.0.0. A subsequent commit (56fc267, also included in 1.0.0) introduced GenerateProxiesCommand, so it's not clear if the CreateCommand methods were ever fully utilized. A related bundle commit to integrate the GenerateProxiesCommand is doctrine/DoctrineMongoDBBundle@75d79b6 (it makes no reference to Createcommand).

For 2.0.0, 4681d8b delegated proxy generation to the separate ProxyManager library.

For additional context, see the git-blame on 2.8.x.

It appears these methods are obsolete, as they are not referenced internally, nor from the Symfony bundle. The Laminas integration doesn't appear to work with console commands at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant