Remove "final" from methods in Table schema class

[aimeos]

Feature Request

What

There are only two methods in the Table schema class which are marked as final, which seems to make no sense:

dbal/src/Schema/Table.php

Lines 274 to 283 in afcd624

	final public function getRenamedColumns(): array
	{
	return $this->renamedColumns;
	}
	/**
	* @throws LogicException
	* @throws SchemaException
	*/
	final public function renameColumn(string $oldName, string $newName): Column

Why

There seems to be no valid reason to make that methods final and using final methods, this makes it impossible to a) overwrite these methods and b) mock them in tests (our problem at the moment).

How

Just remove the "final" method modifier here:

dbal/src/Schema/Table.php

Lines 274 to 283 in afcd624

	final public function getRenamedColumns(): array
	{
	return $this->renamedColumns;
	}
	/**
	* @throws LogicException
	* @throws SchemaException
	*/
	final public function renameColumn(string $oldName, string $newName): Column

[derrabus]

To be honest, I don't find this kind of issue very constructive. The fact that you don't know the reason behind a developer's decision, does not mean that there is "no valid reason" for that decision or that said decision "makes no sense". Just as you probably wouldn't be happy about being told that mocking a state representation of a 3rd party package such as the Table class makes no sense and that there's no valid reason to create such a mock.

[aimeos]

Sorry for my ignorance questioning that decision. What is the reason behind using final for those two methods only?