Proxy generation discards callable type-hint

[natelenart]

As far as I can tell, this is a limitation in PHP itself as there is no $param->isCallable() method defined on ReflectionParameter. I'm not sure if there is any way of detecting callables at the moment (short of string parsing/regex), but it would be nice if the docs had a warning about it too (maybe they do and I haven't seen them).

# Doctrine\Common\Proxy\ProxyGenerator::_generateMethods

// We need to pick the type hint class too
if (null !== $paramClass) {
    $parameterString .= '\\' . $paramClass->getName() . ' ';
} elseif ($param->isArray()) {
    $parameterString .= 'array ';
}

Since callable is neither a class, nor an array, the generator strips it out, which leads to an ErrorException because the type-hint is not compatible with its parent:

Runtime Notice: Declaration of Proxies__CG__\Acme\DemoBundle\Entity\Subclass::methodCall() should be compatible with Acme\DemoBundle\Entity\Superclass::methodCall(callable $conditions) in /var/www/lab/app/cache/dev/doctrine/orm/Proxies/__CG__AcmeDemoBundleEntitySubclass.php line 8

In the meantime, I can easily change my code to remove the type-hint and check is_callable myself in my method.

I hope this is the right place to post this as current stable has the proxy generation code in ORM, but it has been moved to Common in the master branch.

[Ocramius]

@natelenart this is the right place for such an issue.

Can you confirm that following is broken then?

class Entity 
{
    public $id;
    public function setFoo(callable $foo) {}
}

[natelenart]

Confirmed with latest dev: https://gist.github.com/natelenart/5110547

[Ocramius]

I'm on it

[nick4fake]

There is still an issue.
schmittjoh/JMSAopBundle#24

It seems that this bug still present in latest version.

[Ocramius]

@nick4fake in common? I solved this issue in zendframework/zend-code, but not in schmittjoh/cg-library.

[nick4fake]

@Ocramius sorry, that bundle uses own library for generating proxies? Then this is certainly not doctrine issue.

[Ocramius]

@nick4fake I don't think that it uses doctrine/common, no.