Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend deprecation notice #486

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

derrabus
Copy link
Member

@@ -4,6 +4,10 @@ which are a native replacement for annotations. As such, this library is
considered feature complete, and should receive exclusively bugfixes and
security fixes.

We do not recommend using this library in new projects and encourage authors
Copy link
Member

@malarzm malarzm Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add # Project deprecated or something like this at the top so there's something big screaming "don't use me" :)

Also maybe a link to our blogpost https://www.doctrine-project.org/2022/11/04/annotations-to-attributes.html like "This is how Doctrine handled migration" to help folks discover this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the ⚠️ is enough in that regard. I've added a link to the blog.

@derrabus
Copy link
Member Author

derrabus commented Sep 5, 2024

I completely forgot about this one. Shall we merge the change before we make a bugfix release?

@malarzm @greg0ire

@greg0ire
Copy link
Member

greg0ire commented Sep 5, 2024

Sure, it just touches documentation so…

@derrabus derrabus merged commit 28d74e5 into doctrine:1.14.x Sep 5, 2024
12 checks passed
@derrabus derrabus deleted the docs/switch-to-attributes branch September 5, 2024 09:26
derrabus added a commit that referenced this pull request Sep 5, 2024
* 1.14.x:
  Extend deprecation notice (#486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants