Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on initial load of slider if we click on first dot with stopAutoPlayOnSlide set as false, it stops working correctly(note: this happens only when slider just loads and hasn't removed hide-slides class from remaining slides) #38

Open
SachinB123 opened this issue Sep 17, 2018 · 9 comments
Assignees
Labels

Comments

@SachinB123
Copy link

on initial load of slider if we click on first dot after it has moved to second or third dot with stopAutoPlayOnSlide set as false, it stops working correctly(note: this happens only when slider just loads and hasn't removed 'hide-slide' class from remaining slides).

A proposed solution would be to remove 'hide-slide' class and instead just provide those non selected class with 'right-slide' class but of course this is proposed as temporary hack and it would be better if you resolved it in your package internally

@dockleryxk
Copy link
Owner

@SachinB123 thank you for finding this! When you say "stops working correctly," do you mean that it stops auto-playing even though it should not?

@SachinB123
Copy link
Author

SachinB123 commented Sep 17, 2018

No, whether it autoplays or not that is not the issue.

This issue can be reproduced on your demo page in following steps:
1> Open your demo page, click second or any dot other than first dot initially.
2>Then click back the first dot, it loads the image which is set on the the last slide of slide array.
3>If autoPlay is on along with stopAutoPlayOnSlide set as false, until the slideshow completes first round of slide array traversal that last slide array image remains stuck.
4>When first round of slide array is traversed, then it starts working perfectly fine and there is no problem thereafter. Problem only occurs in first round and consecutive rounds are error free.

Note: Problem only occurs in initial or first round of slide traversal using dots only but not with arrows, arrows based traversal works fine.

Only possible solution, I could find for this is that initially, not loaded slides are hidden using 'hide-slide' class, so I removed them and in their place I added 'right-slide' class that you had inside your package with left:100% defined which solved it temporarily but since it is an issue so I opened it here.

@dockleryxk
Copy link
Owner

@SachinB123 thank you for this information. I will likely not have time to look into this until this weekend, but I will let you know once I have it resolved.

@dockleryxk dockleryxk added the bug label Sep 17, 2018
@dockleryxk dockleryxk self-assigned this Sep 17, 2018
@dockleryxk
Copy link
Owner

Update: still trying to figure this out. Will look into it more this week.

@alex-osman
Copy link

This could use a fix

@dockleryxk
Copy link
Owner

I think this might just be fixed now, need to verify

@bttb
Copy link

bttb commented Mar 4, 2020

it's definitely not fixed. Will try to investigate tomorrow. another problem I see is that on lazy load it first loads the first image, and then after you slide to another image it loads all other images in one go.

@bttb
Copy link

bttb commented Mar 5, 2020

Okay, I have a solution. How can I push it?

@dockleryxk
Copy link
Owner

@bttb that's awesome! Just make a PR.

FYI: the original intention of lazyLoad was to ensure the rest of the page loaded after everything else, but not necessarily on a slide-by-slide basis. However, that functionality is more closely aligned with what people expect out of lazy loading, so I'm all for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants