Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manage org docs for user invitation flow #21347

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Update manage org docs for user invitation flow #21347

merged 6 commits into from
Nov 8, 2024

Conversation

sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Nov 5, 2024 •
edited
Loading

Description

  • Added user flow for accepting an invitation (was missing before)
  • Reorganized headings on the page:
    • Invite members heading was hidden under the shortcode file and not showing up in left-hand nav
    • Reorganized other headings to make sense for user flow
    • Moved Docker Hub (non tabbed sections) out of shortcode file

Related issues or tickets

ENGDOCS-2299

Reviews

  • Editorial review

Preview: https://deploy-preview-21347--docsdocker.netlify.app/admin/organization/members/

@sarahsanders-docker sarahsanders-docker changed the title Update manage org docs for user invitation flow DRAFT: Update manage org docs for user invitation flow Nov 5, 2024
@github-actions github-actions bot added area/admin Relates to Docker Admin hugo Updates related to hugo labels Nov 5, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 5, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit a1f398e
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/672e34d15b92b5000888ebdb
😎 Deploy Preview https://deploy-preview-21347--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review November 5, 2024 23:00
@sarahsanders-docker sarahsanders-docker requested a review from a team November 5, 2024 23:00
@sarahsanders-docker sarahsanders-docker changed the title DRAFT: Update manage org docs for user invitation flow Update manage org docs for user invitation flow Nov 5, 2024
@sarahsanders-docker sarahsanders-docker requested review from dvdksn and a team and removed request for dvdksn November 6, 2024 22:50
dvdksn
dvdksn requested changes Nov 8, 2024
View reviewed changes
layouts/shortcodes/admin-users.html Outdated Show resolved Hide resolved
@sarahsanders-docker sarahsanders-docker requested review from dvdksn and a team November 8, 2024 15:59
dvdksn
dvdksn approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahsanders-docker sarahsanders-docker merged commit 5ffcf87 into docker:main Nov 8, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdksn dvdksn dvdksn approved these changes

Assignees
No one assigned
Labels
area/admin Relates to Docker Admin hugo Updates related to hugo status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahsanders-docker @dvdksn