Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENGDOCS-2077 #20911

Merged
merged 5 commits into from
Oct 24, 2024
Merged

ENGDOCS-2077 #20911

merged 5 commits into from
Oct 24, 2024

Conversation

aevesdocker
Copy link
Contributor

Description

RHEL moving to GA. This PR makes it visible in the TOC and adds the download links

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/install Relates to installing a product area/desktop Issue affects a desktop edition of Docker. E.g docker for mac labels Sep 16, 2024
@aevesdocker aevesdocker added this to the 4.35 milestone Sep 16, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 9a1f824
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66f52decf70602000865c867
😎 Deploy Preview https://deploy-preview-20911--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker marked this pull request as ready for review September 16, 2024 10:03
@aevesdocker aevesdocker requested a review from a team September 16, 2024 10:04
dvdksn
dvdksn reviewed Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker-ce RHEL installation page also contains a reference about DD@RHEL being early access: https://docs.docker.com/engine/install/rhel/

@dvdksn
Copy link
Collaborator

dvdksn commented Sep 16, 2024 •
edited
Loading

The docker-ce RHEL installation page also contains a reference about DD@RHEL being early access: https://docs.docker.com/engine/install/rhel/

Just confirmed, you can remove the entire callout about RHEL being experimental for docker-ce on that page. https://docker.slack.com/archives/C01370QBN65/p1726487390907009

The installation overview page also needs an update to remove the 🚧 https://docs.docker.com/engine/install/#supported-platforms

@github-actions github-actions bot added the area/engine Issue affects Docker engine/daemon label Sep 17, 2024
dvdksn
dvdksn previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aevesdocker aevesdocker merged commit cb2ded3 into docker:main Oct 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdksn dvdksn dvdksn approved these changes

Assignees
No one assigned
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/engine Issue affects Docker engine/daemon area/install Relates to installing a product status/review
Projects
None yet
Milestone
4.35
Development

Successfully merging this pull request may close these issues.
2 participants
@aevesdocker @dvdksn