Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-2220 #20882

Merged
merged 3 commits into from
Oct 24, 2024
Merged

ENGDOCS-2220 #20882

merged 3 commits into from
Oct 24, 2024

Conversation

aevesdocker
Copy link
Contributor

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 7eb44a2
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66e7fda972c18d0008245f59
😎 Deploy Preview https://deploy-preview-20882--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Sep 13, 2024
@aevesdocker aevesdocker added this to the 4.35 milestone Sep 13, 2024
Copy link
Contributor

@doringeman doringeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mention here that it's not required anymore?
Perhaps something like For Docker Desktop version below 4.35, enable ...?

content/manuals/desktop/faqs/linuxfaqs.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the area/install Relates to installing a product label Sep 13, 2024
@aevesdocker
Copy link
Contributor Author

Should we also mention here that it's not required anymore?

Done!

Copy link
Contributor

@doringeman doringeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@aevesdocker aevesdocker marked this pull request as ready for review September 16, 2024 09:45
@aevesdocker aevesdocker requested a review from a team September 16, 2024 09:45
@aevesdocker aevesdocker merged commit 0413296 into docker:main Oct 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/install Relates to installing a product status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants