Emit events for building images #11498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2024
felixfontein
force-pushed
the
building-events
branch
2 times, most recently
from
066acec
to
63c0310
Compare
felixfontein
force-pushed
the
building-events
branch
from
63c0310
to
9e2faff
Compare
felixfontein
force-pushed
the
building-events
branch
from
9e2faff
to
c9f6d1a
Compare
|
@ndeloof could you maybe take a look at this PR at some point? Thanks :) |
felixfontein
force-pushed
the
building-events
branch
from
c9f6d1a
to
5e7a74a
Compare
|
@ndeloof can you take a look at this? Thanks. |
felixfontein
force-pushed
the
building-events
branch
from
5e7a74a
to
248ca46
Compare
|
Are these events also generated if the image is built by the |
|
I would assume so; I've never used |
felixfontein
force-pushed
the
building-events
branch
from
248ca46
to
c4e15c6
Compare
Signed-off-by: Felix Fontein <[email protected]>
felixfontein
force-pushed
the
building-events
branch
from
c4e15c6
to
e9757e6
Compare
ndeloof
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Right now
docker compose buildordocker compose up --builddoes not emit events. The only way to notice that something was built is by looking at stdout. The only case events are written (to stderr) is when using BuildKit in dry-mode (there's special code to emit some fake events in that case).This PR makes building emit proper events (one before and one after building). This improves using
docker composefrom other programs. (Especially together with #11478.)Related issue
Fixes #11403.
(not mandatory) A picture of a cute animal, if possible in relation to what you did
