Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Docker Compose pull fails when a required env_file is missing #12081

Open
KostaGorod opened this issue Aug 25, 2024 · 1 comment
Open
Labels
area/env .env and env_file kind/feature

Comments

@KostaGorod
Copy link

Description

I Believe this is part of previous requests #1973 & #9181.

which defines that some commands don't need to validate full config.

my issue that when I pull images, using env_file with required=true.
the pull fails due to missing env file.

My expectation is that the required is part of running the compose (and validating), not pulling.
If there is situation that env_file is expected as part of pull (which I'm not aware of such situations), I would expect option to declare that its required only for commands such up but ignored for pull.
for example required: "runtime"

Steps To Reproduce

  1. add to docker-compose.yml
env_file:
  - path: .myservice.env
    required: true
  1. run docker compose pull
  2. command fails due to missing file. - undesired behavior
  3. edit to required: false
  4. command succeeded.
  5. but now docker compose up ignores missing file as well

Compose Version

Docker Compose version v2.25.0

Docker Environment

No response

Anything else?

No response

@ndeloof
Copy link
Contributor

ndeloof commented Aug 28, 2024

Docker Compose indeed fully parse and resolve your compose file before it execute any command, and doing so will detect missing env file whenever this isn't used by the pull command.
This is comparable to #10993

We miss a more flexible mechanism to only load and validate required parts of a compose model depending on command being ran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/env .env and env_file kind/feature
Projects
None yet
Development

No branches or pull requests

3 participants