Fix embed matching for single 0-indexed test attribute #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbadea-heits
approved these changes
Jan 16, 2024
davidcarlsonberg
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
What issue does this relate to?
N/A
What should this PR do?
In a situation where an embed was generated that contained a single test, and the integer assigned to the test was
0(or any value other than1), the embed would not render.This PR changes the logic, so the initial embed detection just relies on the
data-glob-tool-embedattribute alone, with thedata-glob-stringanddata-glob-test-*attributes only being searched for (and validated) in the embed constructor.What are the acceptance criteria?
Demo continues to work, and if the demo is edited to have a single
data-glob-test-0="hello.js"attribute (alongside thedata-glob-tool-embed+data-glob-string), it also continues to work.