Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new haiku in athul_haiku_hacktoberfest.md file #2886

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

Athul28
Copy link
Contributor

@Athul28 Athul28 commented Oct 2, 2023

No description provided.

Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this haiku! There are some changes that need to be made to the syllable count in order to have a valid haiku.

A haiku is composed of 3 lines. The first line is 5 syllables long, the second line is 7 syllables long, and the third line is 5 syllables long. Although the majority of the haikus here are written in English, you can submit a haiku in any human language. Verify your haiku syllables with a checker like Haiku Syllable Counter.

Please consult our contributing guidelines if you need extra guidance. Once you amend this pull request, we can merge it in.

Please note: maintainers will only go through one round of review, first reviews that are not sufficiently addressed will be closed and marked invalid. Also note that after more than two days of inactivity, pull requests are subject to being closed and marked invalid by maintainers.

@Athul28
Copy link
Contributor Author

Athul28 commented Oct 14, 2023

I have fixed the issues please merge my pr

@Athul28
Copy link
Contributor Author

Athul28 commented Oct 17, 2023

@ltagliaferri please merge my pr I have made the required changes

Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this haiku and for contributing to open source 🎉

@ltagliaferri ltagliaferri merged commit 3b6e3e4 into do-community:main Oct 19, 2023
1 check failed
@Athul28 Athul28 deleted the athul_haiku branch October 24, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants