Apply a clip rectangle if a color filter is used #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Feb 2, 2024
jason-simmons
force-pushed
the
bug_142620
branch
from
5f22d9f
to
8db217b
Compare
Skia's SkCanvas::saveLayer does not implicitly clip to the bounds rect. See flutter/flutter#142620
jason-simmons
force-pushed
the
bug_142620
branch
from
364ae0a
to
84c8531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skia's SkCanvas::saveLayer does not implicitly clip to the bounds rect.
See flutter/flutter#142620