Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detailed dataset monitoring #253

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Update detailed dataset monitoring #253

merged 4 commits into from
Nov 13, 2023

Conversation

nikodemas
Copy link
Member

CMSMONIT-580

Included latest created dataset time into detailed dataset monitoring view.

Changes:

  • Updated spark job to calculate LastCreate field and reformatted detailed_datasets.py file. If you don't want to see formatting changes, just review get_df_main_datasets_in_each_rse(spark) function
  • Updated Go and JavaScript code to add the new column

Panos512
Panos512 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@Panos512 Panos512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks Nikodemas!

haozturk
haozturk approved these changes Nov 7, 2023
View reviewed changes
Copy link

@haozturk haozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't test it, but I see that the created_at field is added as asked, so I'm approving.

@nikodemas nikodemas mentioned this pull request Nov 10, 2023
Merged
@nikodemas nikodemas merged commit 4d38d0f into dmwm:master Nov 13, 2023
1 check passed
@nikodemas nikodemas mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leggerf leggerf leggerf approved these changes

@haozturk haozturk haozturk approved these changes

@Panos512 Panos512 Panos512 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikodemas @Panos512 @haozturk @leggerf