Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-nested CSS3D seems to be getting bad in Chrome. #74

Open
trusktr opened this issue Aug 31, 2017 · 5 comments
Open

Non-nested CSS3D seems to be getting bad in Chrome. #74

trusktr opened this issue Aug 31, 2017 · 5 comments

Comments

@trusktr
Copy link

trusktr commented Aug 31, 2017

For example, check out the old Famous periodic table: http://disrupt.famo.us/periodic402/

Look like Chrome hasn't been keeping their CSS3D (non-nested stuff) in good working order, as the demo flickers a lot for me in Chrome 60 in MacOS on a new MacBook Pro I just got in June.

Nested CSS3D seems to be doing better, but it still has problems too.

It might be worth making a nested renderer for Samsara to see which one works better.

@trusktr
Copy link
Author

trusktr commented Aug 31, 2017

It wouldn't be too hard: you would simply not have to calculate world transforms in this case, only nest the elements and apply their local transforms (the HTML engine calculates the world transforms instead, when it traverses the DOM). You'd need to apply preserve-3d to all of them.

I'm sure you know how it works. ;)

@dmvaldman
Copy link
Owner

I am noticing a lot more stuttering. Still not sure as to why though. What's your reason for thinking it has to do with unnested DOM?

@culyun
Copy link
Contributor

culyun commented Sep 30, 2017

It's a pretty recent regression. Tested demo with Opera 46 and Opera 48 on the same box. Opera 46 was smooth, Opera 48 stuttered.

@trusktr
Copy link
Author

trusktr commented Sep 30, 2017

@dmvaldman I'm not sure it's a regression for non-nested DOM actually. Maybe it would be useful having both forms of renderer so that we can test it?

@culyun Nice catch. If you can post that at http://crbug.com, it will help Chrome authors determine which version of Blink caused it since you know the Opera versions.

@culyun
Copy link
Contributor

culyun commented Oct 1, 2017

@trusktr I've reported issue [upstream|https://bugs.chromium.org/p/chromium/issues/detail?id=770545]

NB. one big change that happened in Chrome 60 (I think) was the introduction of webasm. So it might be worth fishing around for other performance regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants