Fix and support python2.x or python3.9 on yarn. #652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2021 18:18
Fix should be classpath and not class_path. Support python2.x and python3.9 such as change threading.isAlive to is_alive or subprocess.call to subprocess.Popen.
szha
reviewed
Jun 23, 2021
|
Closing, as the pull request has been stable. Feel free to re-submit if the change is still necessary. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix no module named 'main.util' that not found file util on yarn.
Fix should be classpath and not class_path.
Support python2.x and python3.9 such as change threading.isAlive to is_alive(https://github.com/python/cpython/blob/87109f4d85c93a870ee8aa0d2b394547d4636b17/Doc/whatsnew/3.9.rst#id717), or change subprocess.call to subprocess.Popen because no args 'env' at method call in python2.x .