Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DLPack diagram to match v1.0 spec #143

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update DLPack diagram to match v1.0 spec #143

merged 1 commit into from
Mar 26, 2024

Conversation

leofang
Copy link
Contributor

@leofang leofang commented Mar 25, 2024 •
edited
Loading

@leofang
Copy link
Contributor Author

leofang commented Mar 25, 2024 •
edited
Loading

hmmm looks like I cropped a png that's too large, @tirthasheshpatel any tips?

@leofang
Copy link
Contributor Author

leofang commented Mar 26, 2024

nvm it looks alright when I build the docs locally:
截圖 2024-03-25 下午8 23 39

@tirthasheshpatel
Copy link
Contributor

Thanks for updating these @leofang! The rendered figure in the docs looks good.

@tqchen tqchen merged commit bbd2f4d into dmlc:main Mar 26, 2024
3 checks passed
@leofang leofang deleted the new_diag branch March 26, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update DLPack diagram in the docs
3 participants
@leofang @tirthasheshpatel @tqchen