Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ByDayFilter #52

Open
dmfs opened this issue Sep 2, 2018 · 0 comments
Open

Split ByDayFilter #52

dmfs opened this issue Sep 2, 2018 · 0 comments

Comments

@dmfs
Copy link
Owner

dmfs commented Sep 2, 2018

In order to make the code simpler (and potentially faster), I want the ByDayFilter to by split into four classes.
dmfs added a commit that referenced this issue Sep 5, 2020
@dmfs
Split ByDayFilter, implements #52
bf0dfe0 
The original ByDayFilter was way to complex and hard to maintain. This commit breaks it into two much simpler classes. A part of the heavy lifting is now done in RecurrenceRule and should be subject to another refactoring.
A nice side effect is a small performance improvement when filtering ByDay.
dmfs added a commit that referenced this issue Sep 5, 2020
@dmfs
Split ByDayFilter, implements #52 (#84)
2741f55 
The original `ByDayFilter` was way to complex and hard to maintain. This commit breaks it into two much simpler classes. A part of the heavy lifting is now done in `RecurrenceRule` and should be subject to another refactoring.
A nice side effect is a small performance improvement when filtering `ByDay`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmfs