Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medusalix appears to be back... Merge time? #8

Open
pallaswept opened this issue Feb 3, 2024 · 14 comments
Open

Medusalix appears to be back... Merge time? #8

pallaswept opened this issue Feb 3, 2024 · 14 comments

Comments

@pallaswept
Copy link

Just noticed lots of commits over there in the past month. He's missing a bunch of your stuff and you're missing a bunch of his. I wonder if a merge could be arranged?

@pallaswept
Copy link
Author

Tried to suggest something over there but his issues section has been removed and PRs are locked to collaborators..... I hope you can find some way to communicate.

@Al-Infinitum
Copy link

I hope you can find some way to communicate.

I just discovered there's an active conversation with Medusalix on discord, message below specifically mentions merging the fork.
https://discord.com/channels/733964971842732042/819644054563192846/1192972953827164261

@pallaswept
Copy link
Author

I hope you can find some way to communicate.

I just discovered there's an active conversation with Medusalix on discord, message below specifically mentions merging the fork. https://discord.com/channels/733964971842732042/819644054563192846/1192972953827164261

Thanks for the update. I joined real quick to take a look and it's clear from several conversations that medusalix is well aware of the fork and that there are various patches that need to be merged, so hopefully that'll work itself out in time.

@Fxzzi
Copy link

Fxzzi commented Apr 5, 2024

I think getting these merged will be very useful considering people (including myself) experience issues on base xone which this fork explicitly fixed. I get random disconnects on xone-dkms-git which I don't get here, etc

@dlundqvist
Copy link
Owner

I think getting these merged will be very useful considering people (including myself) experience issues on base xone which this fork explicitly fixed. I get random disconnects on xone-dkms-git which I don't get here, etc

Did that happen in the past to with upstream or is that a new problem?

@dlundqvist
Copy link
Owner

Just noticed lots of commits over there in the past month. He's missing a bunch of your stuff and you're missing a bunch of his. I wonder if a merge could be arranged?

Of course my life turned busy when he came back. I'll look into what he's missing from here and try to coordinate something.

@Fxzzi
Copy link

Fxzzi commented May 25, 2024

Did that happen in the past to with upstream or is that a new problem?

I think it's an issue related to which band the receiver is being connected by. Not sure exactly when it started but I don't think it was any time recently

@dlundqvist
Copy link
Owner

Did that happen in the past to with upstream or is that a new problem?

I think it's an issue related to which band the receiver is being connected by. Not sure exactly when it started but I don't think it was any time recently

I just merged in upstream's changes. I did not see any changes to channel management so it should still work for you.

@dlundqvist
Copy link
Owner

dlundqvist commented May 25, 2024

I also started to create PR:s for commits upstream are missing.

@pallaswept
Copy link
Author

You've been very busy today, we all appreciate it mate!

@Fxzzi
Copy link

Fxzzi commented May 25, 2024

I've created an AUR package to install this fork until everything gets merged: https://aur.archlinux.org/packages/xone-dlundqvist-dkms-git

Thanks so much for your work!!

@adamdmoss
Copy link

adamdmoss commented Sep 6, 2024

Just popping in here to say I only just discovered this fork - and it seems to have a bunch of nice-looking stuff that upstream still doesn't have yet (or have PRs for?) that still seems to leave this fork more reliable than upstream. Kudos!

As a spectator I'm particularly intrigued by a3d95ec and b3b1a37 which I suspect are solving various reliability issues for me.

@dlundqvist
Copy link
Owner

Happy to help. According to author a3d95ec is not the best solution, but it does seem to solve issues for many so for now I'm leaving it in. I actually just now saw a bug in b3b1a37, where it does the wrong thing if xone_dongle_toggle_pairing fails. I should be able to fix that soonish.

@markmb88
Copy link

6.11 brought me here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants