Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdmd_test.d: Make model flag optional #470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

the-horo
Copy link

The -m switch only makes sense on amd64 or x86. Making the flag optional allows running the tests on other architectures.

The -m switch only makes sense on amd64 or x86. Making the flag
optional allows running the tests on other architectures.

Signed-off-by: Andrei Horodniceanu <[email protected]>
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @the-horo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + tools#470"

@CyberShadow
Copy link
Member

Do we need to bump dlang-community/setup-dlang?

@the-horo
Copy link
Author

I've made the PR in order to be able to run tests on aarch64. There, ldc2 handles -m64 and probably ignores it, but gdc fails with an unrecognized option. I've tried to keep the old behavior the same so I'm not sure why a bump would be needed.

@CyberShadow
Copy link
Member

Makes sense, though my comment was directed at the failing jobs on macOS.

but gdc fails with an unrecognized option

My vague understanding is that the relationship between AArch64 and 32-bit ARM is roughly the same as between x86_64 and x86. Would it make sense to look into whether it would be better for GDC on ARM to have a -m flag as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants