Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.uni: optimize fullCaseTable #8880

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jan 6, 2024

Reduce table size from 50kb to 25kb by cutting the entry size in half (16 -> 8 bytes), and shave off 12 ms semantic2 time by using plain integers.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8880"

@dkorpel
Copy link
Contributor Author

dkorpel commented Jan 7, 2024

std/internal/unicode_tables.d(40:8)[warn]: Public declaration 'FCE' has no documented example.

FCE is package(std), bug in D-scanner?

@dlang-bot dlang-bot merged commit fbc05d5 into dlang:master Jan 8, 2024
13 checks passed
@dkorpel dkorpel deleted the unicode-fce branch January 8, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants