Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Makefile: Compile zlib .c files with DMD via importC" #8870

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jan 1, 2024

Reverts #8865

Broke dmd mainline, and release builds.

Error: C preprocess command C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x86\cl.exe failed for file etc\c\zlib\compress.c, exit status 2

Error: C preprocess command C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x86\cl.exe failed for file etc\c\zlib\deflate.c, exit status 2

cl : Command line warning D9002 : ignoring unknown option '/Zc:preprocessor'
cl : Command line warning D9002 : ignoring unknown option '/PD'
etc\c\zlib\deflate.c: fatal error C1083: Cannot open include file: '../dmd/druntime/import\importc.h': No such file or directory
Error: C preprocess command C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x86\cl.exe failed for file etc\c\zlib\adler32.c, exit status 2

cl : Command line warning D9002 : ignoring unknown option '/Zc:preprocessor'
cl : Command line warning D9002 : ignoring unknown option '/PD'
etc\c\zlib\compress.c: fatal error C1083: Cannot open include file: '../dmd/druntime/import\importc.h': No such file or directory
cl : Command line warning D9002 : ignoring unknown option '/Zc:preprocessor'
cl : Command line warning D9002 : ignoring unknown option '/PD'
etc\c\zlib\adler32.c: fatal error C1083: Cannot open include file: '../dmd/druntime/import\importc.h': No such file or directory
Error: C preprocess command C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x86\cl.exe failed for file etc\c\zlib\crc32.c, exit status 2

cl : Command line warning D9002 : ignoring unknown option '/Zc:preprocessor'
cl : Command line warning D9002 : ignoring unknown option '/PD'
etc\c\zlib\crc32.c: fatal error C1083: Cannot open include file: '../dmd/druntime/import\importc.h': No such file or directory
mingw32-make: *** [Makefile:322: generated/windows/release/32/etc/c/zlib/deflate.obj] Error 1
mingw32-make: *** Waiting for unfinished jobs....
mingw32-make: *** [Makefile:322: generated/windows/release/32/etc/c/zlib/compress.obj] Error 1
mingw32-make: *** [Makefile:322: generated/windows/release/32/etc/c/zlib/adler32.obj] Error 1
mingw32-make: *** [Makefile:322: generated/windows/release/32/etc/c/zlib/crc32.obj] Error 1
create_dmd_release: Error: Command failed (ran from dir 'clones\phobos'): "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Auxiliary\Build\vcvarsall.bat" amd64_x86 && mingw32-make -j4 MODEL=32 "DMD=C:\Users\vagrant\clones/dmd/generated/windows/release/32/dmd.exe" ENABLE_RELEASE=1 LATEST=master

Sorry @kinke - please try again after release freeze.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8870"

@ibuclaw ibuclaw added Blocking Other Work Regression PRs that fix regressions labels Jan 1, 2024
@ibuclaw ibuclaw merged commit 3a24b0e into master Jan 1, 2024
5 of 20 checks passed
@ibuclaw ibuclaw deleted the revert-8865-zlib_importc branch January 1, 2024 17:30
@kinke
Copy link
Contributor

kinke commented Jan 1, 2024

[Sorry for the trouble.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking Other Work Regression PRs that fix regressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants