Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Revive 1989: Thread detach stability #2966

Conversation

MoonlightSentinel
Copy link
Contributor

Rebases #1989. The original PR was already approved but got stalled because of a TLS issue AFAICT,

Let's see whether this issue was resolved since then.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
18063 major thread_attachThis returns dangling pointer

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#2966"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Mar 1, 2020
@MoonlightSentinel
Copy link
Contributor Author

Well, seems like there are some remaining issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants