Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webinterface: fix gist user discovery requests #760

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ljmf00
Copy link
Member

@ljmf00 ljmf00 commented Oct 21, 2020

Since URL.path.bySegment returns [, run-dlang, <gist-id>] when the request path
is /run-dlang/<gist-id>, first value should be discarded if empty.

Signed-off-by: Luís Ferreira [email protected]


Fixes #739 .

@ljmf00
Copy link
Member Author

ljmf00 commented Oct 26, 2020

@wilzbach can you review this?

@Imperatorn
Copy link

@wilzbach can you review this?

Sadly, @wilzbach isn't maintaining this anymore.

@ljmf00
Copy link
Member Author

ljmf00 commented Dec 11, 2022

@wilzbach can you review this?

Sadly, @wilzbach isn't maintaining this anymore.

Perhaps, someone else can review this.

Since URL.path.bySegment returns [, run-dlang, <gist-id>] when the request path
is '/run-dlang/<gist-id>', first value should be discarded if empty.

Signed-off-by: Luís Ferreira <[email protected]>
Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you get rid of the unrelated whitespace changes ?

source/webinterface.d Outdated Show resolved Hide resolved
source/webinterface.d Outdated Show resolved Hide resolved
source/webinterface.d Outdated Show resolved Hide resolved
source/webinterface.d Outdated Show resolved Hide resolved
@ljmf00
Copy link
Member Author

ljmf00 commented Dec 24, 2022

Could you get rid of the unrelated whitespace changes ?

I'll checkout this locally as soon as I have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run.dlang.io: “Shorten” and “Export Gist” buttons not working
3 participants