-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Execution
to the types.ExecuteRequest
struct
#1307
Comments
cobolbaby
changed the title
Expand the
Add Mar 29, 2023
reportingWriter
struct and add job metadata*Execution
to the *types.ExecuteRequest
struct
cobolbaby
changed the title
Add
Add Mar 29, 2023
*Execution
to the *types.ExecuteRequest
structExecution
to the types.ExecuteRequest
struct
Can you explain what metadata do you want to include? |
Currently I need to get the following attributes, such as ExecutionId, ExecutionStartTime, ExecutionNodeName. Lines 13 to 40 in 9982ceb
Then pass it to the shell command as a custom environment variable. func (s *Shell) ExecuteImpl(args *dktypes.ExecuteRequest, cb dkplugin.StatusHelper) ([]byte, error) {
....
executionInfo := strings.Split(
fmt.Sprintf("ENV_JOB_NAME=%s,ENV_EXECUTION_ID=%s,ENV_EXECUTION_NODENAME=%s",
args.JobName, args.Execution.Id, args.Execution.NodeName), ",")
env = append(env, executionInfo...)
cmd, err := buildCmd(command, shell, env, cwd) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
I wish to add
Execution
metadata to thereportingWriter
struct to implement some extended features. However, to achieve this, it is necessary to adjust the structure of the ExecuteRequest. I am not sure whether such a request is acceptable.Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
dkron/dkron/grpc_agent.go
Lines 84 to 94 in 53864a0
The text was updated successfully, but these errors were encountered: