Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some operations on the weights may underflow #14

Closed
matteojug opened this issue Sep 26, 2024 · 0 comments · Fixed by #18
Closed

Some operations on the weights may underflow #14

matteojug opened this issue Sep 26, 2024 · 0 comments · Fixed by #18

Comments

@matteojug
Copy link

Some operations on the weights may underflow (eg, if self.messages_1b_weight >= self.cfg.threshold - self_weight { ...}): (as #13 test, but with) weights = vec![100, 1, 2, 3, 4];
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: resolve issues around leader election distributed-lab/bpcon
1 participant
@matteojug