FIX: Use correct user_id field from return auth result #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are currently using the wrong oauth result field 'id' instead of 'user_id'. This means the provider_uid looks something like 'https://login.salesforce.com/id/<organisation-id>/<provider-uid>' now but it should be '<provider-uid>' instead. This requires a migration as well.
nattsw
force-pushed
the
use-correct-user-id
branch
from
586098f
to
8793276
Compare
ZogStriP
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using the wrong oauth result field
idinstead ofuser_id. This means the provider_uid looks something likehttps://login.salesforce.com/id/<organisation-id>/<provider-uid>now but it should be<provider-uid>instead.This requires a migration as well. There is a test but can be removed once this PR is approved. One can refer to https://demo.discourse.group/t/troubleshooting-salesforce-auth/33 on an example payload.