Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend pagination POC #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rgmz
Copy link

@rgmz rgmz commented Jun 27, 2024

This is a proof-of-concept for supporting backend pagination. It fixes #33.

Most of the heavy lifting is done by Flask SQLAlchemy

TODO (?):

  • Implement pagination for all endpoints

Frontend

  • Create a common component for a paginated table (?)
  • Tweak implementation to closer match this (?)
  • Add loading icon to provide feedback
  • Fix pagination total count + number of pages (currently just says 1-n of n, where n is the number of items for a single page)
  • Surface any backend errors via a popup (or something; don't fail silently)
  • Add debounce for filter input

Backend

  • Update backend responses to include total count of items

@rgmz rgmz force-pushed the feat/server-side-pagination branch from 1732732 to a6baa51 Compare July 3, 2024 13:44
@rgmz rgmz marked this pull request as ready for review October 18, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] [feature request] No results when database is huge - introduce results paging
1 participant