Fix issue #7 and add support for 'validate mode' #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate mode will check all filled in cells (i.e. all cells not being "void") and indicate with a red cell border if cell value isn't correct. Can be used to verify that current level solution is on track instead of completing the level only to find out that there is an error somewhere. This can be very annoying in the more difficult levels where one can spend hours trying to find correct solution.
…grid Bind contextX,Y for indicator bars and grid depending on state to make sure that they don't end up out of sync.
|
The fix for the scrolling issue looks very clean! Validate mode sounds interesting. If it is what I assume it is, it is an easy way to get through any level. I'm not sure if that's too powerful tool to have enabled by default. I'll have to test it to see what is actually does. It may be better to put a flag for it in settings, for example. (Cheat mode is not the place.) Or alternatively mark that the level has been completed with using validate mode. I'd like to keep the levels "more challenging" by default. Thanks for the contributions! I'll give these a spin next! |
|
Thanks! Feel free to do what you want with the validate mode patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements...