Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid front matter separately from the rest of the content #518

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

brotheroftux
Copy link
Contributor

This is a remedy for issues discovered post-merge of diplodoc-platform/cli#833.

@brotheroftux brotheroftux force-pushed the frontmatter-liquid-fix branch 2 times, most recently from 10e33de to 45a919b Compare September 20, 2024 17:33
Copy link
Contributor

@Feverqwe Feverqwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but overhead for md2md mode


import {FrontMatter, frontMatterFence, unescapeLiquidSubstitutionSyntax} from './common';

export const serializeFrontMatter = (frontMatter: FrontMatter) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the problem we are solving in this PR valid only for meta or for all yaml pages too?

@brotheroftux brotheroftux merged commit 7230d7f into master Sep 30, 2024
1 check passed
@brotheroftux brotheroftux deleted the frontmatter-liquid-fix branch September 30, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants