feat: add async transform support #866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makamekm
force-pushed
the
add-async-transform-support
branch
2 times, most recently
from
2843e41
to
15931eb
Compare
makamekm
force-pushed
the
add-async-transform-support
branch
from
60dbb57
to
2246641
Compare
3y3
reviewed
Nov 4, 2024
| shell.mkdir('-p', outputDir); | ||
| } | ||
|
|
||
| await copyFile(from, to); |
There was a problem hiding this comment.
Так нельзя. Это замедляет сборку.
В отличии от shall.cp, который делает новый hardlink, нода честно копирует контент файла, что намного медленнее.
3y3
reviewed
Nov 4, 2024
| } | ||
| } | ||
|
|
||
| export class FsContextCli implements FsContext { |
There was a problem hiding this comment.
Зачем перепридумывать fs api?
Почему то, что было *Sync перешло в *, а то что было * перешло в *Async?
3y3
reviewed
Nov 4, 2024
| this.context = context; | ||
| } | ||
|
|
||
| getPaths(path: string) { |
There was a problem hiding this comment.
Это не может быть публичным АПИ.
fs должен быть совместим с import type * as fs from 'node:fs/promises'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.