Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minification #8

Open
asdfzt opened this issue May 10, 2016 · 2 comments
Open

Add minification #8

asdfzt opened this issue May 10, 2016 · 2 comments
Assignees
@asdfzt
Labels
build

Comments

@asdfzt
Copy link
Collaborator

asdfzt commented May 10, 2016

No description provided.

@asdfzt asdfzt added the feature label May 10, 2016
@asdfzt asdfzt self-assigned this Oct 1, 2016
asdfzt added a commit that referenced this issue Oct 1, 2016
@asdfzt
Issue #8 - Add Minification
a799588 
Using babels babili for minification of js files. The babili preset only works when NODE_ENV=production. This is encapsulated in the build:prod command. *Note - using cross-env for windows support.
@asdfzt
Copy link
Collaborator Author

asdfzt commented Oct 1, 2016

Whoops - totally forgot that Angular minification is..."special." Will need to setup either ng-annotate or explicit di for each js file. The only potential problem with using ng-annotate is the lack of support for ES6 (although we are not currently using many ES6 features - so this may still be ok).

@diminutivesloop
Copy link
Owner

Are we not able to run ng-annotate after the es6 code has been transpiled to a compatible js version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asdfzt asdfzt

Labels
build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diminutivesloop @asdfzt