Merge pull request improbable-eng#38 from digitalocean/varsha/eco-cle…

…anup

delete old backup objects only if successfully completed

controllers/etcdbackupschedule_controller.go

@@ -196,7 +196,7 @@ func (r *EtcdBackupScheduleReconciler) cleanup(resourceNamespacedName types.Name
 	for i, backup := range etcdBackups.Items {
 		backup := backup
 		funcs[i] = func() error {
-			if cleanAll || backup.Status.Phase != etcdv1alpha1.EtcdBackupPhaseBackingUp {
+			if cleanAll || backup.Status.Phase == etcdv1alpha1.EtcdBackupPhaseCompleted {
 				if err := r.Delete(ctx, &backup); err != nil {
 					return client.IgnoreNotFound(err)
 				}