Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display issues especially with Subject Name on Public Links #98

Closed
bmuramatsu opened this issue Sep 7, 2023 · 7 comments
Closed

Display issues especially with Subject Name on Public Links #98

bmuramatsu opened this issue Sep 7, 2023 · 7 comments
Assignees
@alexfigtree
Milestone
0.1.1

Comments

@bmuramatsu
Copy link
Collaborator

In version 98c0a2a 0.1.0 of VerifierPlus, there are display issues for the Subject Name field.

  1. Subject Name should be styled as other fields Issuer, Issuance Date, Criteria
  2. There may be excess space between Subject Name and Issuance Date
  3. We may want to add the Description label back in for clarity, the display read ok without it prior to adding in Subject Name where it is located. It may have also been removed accidentally.
@lautom36
Copy link
Contributor

Below is what the verification page like after changes 1 and 2. Would you like me to add the Description label back?

Screenshot 2023-09-28 at 3 21 25 PM

@lautom36 lautom36 mentioned this issue Sep 28, 2023
Merged
@kayaelle
Copy link
Member

@bmuramatsu - I think we should add the description label back. What do you think?

@kayaelle
Copy link
Member

@lautom36 - when testing #104 I see that the description field has been added.

@kayaelle
Copy link
Member

Description field is set to display.

@alexfigtree alexfigtree added this to the 0.1.1 milestone Feb 21, 2024
@alexfigtree
Copy link
Member

Description is being displayed with space issues fixed. Closing this ticket.

Image

@alexfigtree
Copy link
Member

Keeping open until after deployment

@alexfigtree alexfigtree reopened this Feb 21, 2024
@alexfigtree
Copy link
Member

Deployed on 3/18/24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexfigtree alexfigtree

Labels
None yet
Projects
DCC Engineering
Status: Done (Deployed)
Milestone
0.1.1
Development

No branches or pull requests
7 participants
@jbasdf @kayaelle @bmuramatsu @alexfigtree @jennacioffi @lautom36 @IsaacAirmet1