(Issue #518) SVG to PDF conversion code #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@kayaelle @dmitrizagidulin we need to talk about the dynamic part (handlebars) in our next meeting before we can account for that |
|
App properly converts valid handlebars into the pdf (the other two handlebars data is not in here because they are improperly labeled/named in the svg template):
|
|
@dmitrizagidulin @kayaelle ready for review. NOTE: The logic was moved to |
|
@dmitrizagidulin Tested and this works still so you can merge following the steps github tells you to manage to rebase it |
Co-authored-by: Dmitri Zagidulin <[email protected]>
Co-authored-by: Dmitri Zagidulin <[email protected]>
Co-authored-by: Dmitri Zagidulin <[email protected]>
Co-authored-by: Dmitri Zagidulin <[email protected]>
…d exists & pdf returned is not null
dmitrizagidulin
force-pushed
the
atomic-jolt/svg-to-pdf
branch
from
849bccf
to
944d887
Compare
|
Conflicts resolved, merging and releasing for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #518
Note:
The top value to fill in (CredentialSubject.name) seems off center but we have applied no styling changes so I am not sure why this occurs.