Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Nav Share, "Create a public link" displays "GT Guide" onscreen after creating the link. #490

Closed
bmuramatsu opened this issue Aug 22, 2023 · 4 comments · Fixed by #501
Assignees
Milestone

Comments

@bmuramatsu
Copy link
Collaborator

Occurs in LCW v2.0.11-build 66 on iOS and Android.

(I can't find "GT Guide" text in the JSON of the all the credentials I've tried, nor did a search in the repo turn up anything except for inside mock credentials.) Attached is a credential where one can see the issue.

To reproduce:

  • Add a credential to LCW
  • From the bottom nav, select the share icon
  • Select "Create a public link"
  • Select (any) credential, and "Create Link" from the "Are you sure?" modal
  • Note GT Guide at the top of the interstitial screen when the Public Link is getting created and on the resulting Public Link (Beta) screen.

Bottom Nav, Share Screen

Interstitial as Public Link getting created—Note GT Guide

Resulting Public Link screen—Note GT Guide

@kayaelle kayaelle added this to the BCSI milestone Aug 28, 2023
@kayaelle
Copy link
Member

Checking on credential name display

@kayaelle
Copy link
Member

"GT Guide" displays no matter what the credential name is. Please change so that the credential name of the chosen credential is displayed.

@IsaacAirmet1
Copy link

#501

@kayaelle
Copy link
Member

kayaelle commented Sep 6, 2023

Confirmed that the chosen credential name displays (instead of GT GUIDE) in both ioS and android

@kayaelle kayaelle reopened this Sep 6, 2023
@kayaelle kayaelle closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (Deployed)
6 participants